Fix to compare input for iteratables. (#229)

sinonjs · Oct 31, 2022 · aa3badb · aa3badb
1 parent 58480cc
commit aa3badb
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 4 deletions.
diff --git a/lib/deep-equal.js b/lib/deep-equal.js
@@ -196,12 +196,12 @@ function deepEqualCyclic(actual, expectation, match) {
             !isArrayType(actualObj) &&
             !isArguments(actualObj);
         var isExpectationNonArrayIterable =
-            isIterable(expectation) &&
-            !isArrayType(expectation) &&
-            !isArguments(expectation);
+            isIterable(expectationObj) &&
+            !isArrayType(expectationObj) &&
+            !isArguments(expectationObj);
         if (isActualNonArrayIterable || isExpectationNonArrayIterable) {
             var actualArray = Array.from(actualObj);
-            var expectationArray = Array.from(expectation);
+            var expectationArray = Array.from(expectationObj);
             if (actualArray.length !== expectationArray.length) {
                 return false;
             }

diff --git a/lib/deep-equal.test.js b/lib/deep-equal.test.js
@@ -924,4 +924,48 @@ describe("deepEqual", function () {
             assert.isFalse(checkDeep);
         });
     });
+
+    describe("nested iterable", function () {
+        let buildInstance;
+
+        before(function () {
+            class Foo {
+                constructor(size = 0) {
+                    this.size = size;
+                }
+            }
+            Foo.prototype[Symbol.iterator] = function () {
+                var count = 1;
+                var size = this.size;
+                return {
+                    next: function () {
+                        return count <= size
+                            ? { value: count++, done: false }
+                            : { value: undefined, done: true };
+                    },
+                };
+            };
+            buildInstance = function (size) {
+                return new Foo(size);
+            };
+        });
+
+        it("return true if same size", function () {
+            assert.isTrue(
+                samsam.deepEqual(
+                    { a: buildInstance(2) },
+                    { a: buildInstance(2) }
+                )
+            );
+        });
+
+        it("return false if different size", function () {
+            assert.isFalse(
+                samsam.deepEqual(
+                    { a: buildInstance(2) },
+                    { a: buildInstance(3) }
+                )
+            );
+        });
+    });
 });