Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme #76

Closed
wants to merge 1 commit into from
Closed

Update Readme #76

wants to merge 1 commit into from

Conversation

olefrank
Copy link

@olefrank olefrank commented Aug 5, 2017

Note to users that current version is not yet compatible with sinon@3

@olefrank
Update Readme
12f0c1d 
Note to users that current version is not yet compatible with sinon@3
@coveralls
Copy link

coveralls commented Aug 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 95.082% when pulling 12f0c1d on olefrank:patch-1 into 51e9ac6 on sinonjs:master.

@fatso83
Copy link
Contributor

fatso83 commented Aug 7, 2017

It isn't? Please make me understand why - preferably with an issue that shows the problem.

@FlorentD
Copy link

FlorentD commented Aug 7, 2017 •
edited
Loading

It looks like this PR from sinon #1506 remove a deprecated method getConfig.
But in sinon-test you use this one with utils.isSinon : typeof obj.getConfig === 'function'.
So it returns always false and it fails !
I open an issue here #77

@fatso83
Copy link
Contributor

fatso83 commented Aug 7, 2017

I'm closing this, as #78 will rectify the shortcoming.

@fatso83 fatso83 closed this Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olefrank @coveralls @fatso83 @FlorentD