Merge pull request #634 from GCheung55/bug-633

Fix #633. Use a try/catch when deleting a property in IE8.
sinonjs · Jan 6, 2015 · 9502572 · 9502572
2 parents 1cbaec0 + c95aa3f
commit 9502572
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/sinon/sandbox.js b/lib/sinon/sandbox.js
@@ -100,7 +100,12 @@
             restoreContext: function () {
                 if (this.injectedKeys) {
                     for (var i = 0, j = this.injectedKeys.length; i < j; i++) {
-                        delete this.injectInto[this.injectedKeys[i]];
+                        // Use a try/catch to delete a property in IE8
+                        try {
+                            delete this.injectInto[this.injectedKeys[i]];
+                        } catch (e) {
+                            this.injectInto[this.injectedKeys[i]] = undefined;
+                        }
                     }
                     this.injectedKeys = [];
                 }

diff --git a/test/sinon/issues/issues.js b/test/sinon/issues/issues.js
@@ -19,7 +19,7 @@ buster.testCase("issues", {
     tearDown: function () {
         this.sandbox.restore();
 
-        if (this.clock){
+        if (this.clock) {
             this.clock.restore();
         }
     },