Drop node 12

And embrace Node 18 See https://nodejs.org/en/about/releases/
sinonjs · May 7, 2022 · c2bbd82 · c2bbd82
1 parent 18d5601
commit c2bbd82
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -143,7 +143,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12, 14, 16]
+        node-version: [14, 16, 18]
 
     steps:
       - uses: actions/checkout@v2

diff --git a/lib/sinon/default-behaviors.js b/lib/sinon/default-behaviors.js
@@ -269,6 +269,7 @@ var defaultBehaviors = {
         Object.defineProperty(rootStub.rootObj, rootStub.propName, {
             value: newVal,
             enumerable: true,
+            writable: true,
             configurable:
                 rootStub.shadowsPropOnPrototype ||
                 isPropertyConfigurable(rootStub.rootObj, rootStub.propName),