Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sandbox.resetHistory() do not resets spied getters or setters #1638

Closed
flakekun opened this issue Dec 21, 2017 · 2 comments
Closed

sandbox.resetHistory() do not resets spied getters or setters #1638

flakekun opened this issue Dec 21, 2017 · 2 comments
Labels
Bug Help wanted Needs investigation

Comments

@flakekun
Copy link

What did you expect to happen?
Calls that was counted for spied getter through sandbox should have been zeroed after call to sandbox.resetHistory()

What actually happens
called property on getter spy is true after call to sandbox.resetHistory(). You have to manually reset getter calls by implicit call without sandbox.

How to reproduce
https://codepen.io/flakekun/pen/jYroWB?editors=0012
@flakekun
Copy link
Author

Forgot to mention nodejs version, it is 8.9.1

@flakekun flakekun changed the title sanbox.resetHistory() do not resets spied getters or setters sandbox.resetHistory() do not resets spied getters or setters Dec 27, 2017
mroderick added a commit to mroderick/sinon that referenced this issue Jan 26, 2018
@mroderick
Fix sinonjs#1638: Make resetHistory work for props also
03369eb
@mroderick mroderick mentioned this issue Jan 26, 2018
Merged
2 tasks
@mroderick
Copy link
Member

This has been fixed in sinon@4.2.2

franck-romano pushed a commit to franck-romano/sinon that referenced this issue Oct 1, 2019
@mroderick
Fix sinonjs#1638: Make resetHistory work for props also
98c35f2
@dependabot dependabot bot mentioned this issue Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Help wanted Needs investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump sinon from 2.3.2 to 9.2.4 dimagi/commcare-hq
2 participants
@mroderick @flakekun