-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stub(obj, 'meth', fn) has been removed, see documentation #1761
Comments
Forget about it, for some reason Google search "sinon stub" point to the 2.0.0 documentation. |
For those finding this by Google searching the error message, the updated docs are here: http://sinonjs.org/releases/v5/stubs/ It looks like the new form is
|
@mroderick: It's unfortunate that people end up creating issues due to our (?) SEO strategy, so maybe it's time to look at the suggestion I once had for fixing the out of date Google searches. I could start out with detailing the issue and a potential fix (as per our Twitter discussion of .. 2016?). AFAI remember the suggested fix was doing something like Django, that foresakes some semantic correctness through canonical link manipulation to improve SEO by always having Google hits point to /latest. The details escape me ATM, but it was conceptually simple. It is just doing it using Jekyll that was the hurdle, AFAI can recall :-) |
Would it be possible to have a banner at the top of old versions stating that these docs are outdated? That wouldn’t improve the search results, but at least it’s more obvious to visitors. |
@mantoni Yeah, exactly one of the things that came up in my Twitter exchange with Morgan:
|
I think that using banners and Ultimately, I'd like to have a better documentation website.
|
as for today, i still come to this as the top google search result for |
Made it here after upgrading Sinon from v2 to v11 (!!!!!!!) Thanks for explaining the required refactor 👍 |
The change seems to have occurred in v3, not v5, and the updated docs are now here: |
We deprecated it in version 2 and removed it in version 3, yes :-) P.S. Updated the links mentioned in the comments, since we decided to just keep docs per major version. |
When I use the following code, I have an error:
stub(obj, 'meth', fn) has been removed, see documentation
I then check the documentation:
http://sinonjs.org/releases/v2.0.0/stubs/#var-stub--sinonstubobject-method-func
I'm using sinon 4.3.
The text was updated successfully, but these errors were encountered: