Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
yarn test
on Windows 10 x64, with Node v10.15.3, the current version ofnode-pcsclite
produces the following error:This causes all tests to fail on my system. This is related to a deprecation / API change in Sinon:
sinonjs/sinon#1761 (comment)
Some other things I've noticed:
This PR addresses issues with the test suite by:
test.js
.sinon
dependency inpackage.json
to^7.3.2
(latest release).new Buffer()
calls toBuffer.from()
.pcsc.js
.get_reader()
test helper so it uses the correct end marker for reader names (fixes the "#connect()" test).