Remove polyfill for Promise #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ramifications of letting the Promise polyfill enter the main Sinon code escaped me at the time I reviewed sinonjs#1211, but it struck me when reviewing sinonjs#1215 that had similar issues. In short: having the polyfill bundled with Sinon will lead to false negatives: running tests using Sinon will then give the impression that code works on platforms that does not support the features that were polyfilled. This reverts the introduction of `native-promise-only` in the main code and moves it to its proper place: the test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ramifications of letting the Promise polyfill enter the main Sinon code escaped me at the time I reviewed #1211, but it struck me when reviewing #1215 that had similar issues. In short:
This reverts the introduction of
native-promise-onlyin the maincode and moves it to its proper place: the test code.