Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reference to deprecated API #1365

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Fix Reference to deprecated API #1365

merged 1 commit into from
Mar 27, 2017

Conversation

h-cow
Copy link
Contributor

@h-cow h-cow commented Mar 25, 2017

Purpose (TL;DR) - mandatory

Fix Reference to deprecated API

Background (Problem in detail) - optional

I tried to follow the docs and got the following warning message.
"sinon.stub(obj, 'meth', fn) is deprecated and will be removed from the public API in a future version of sinon. Use stub(obj, 'meth').callsFake(fn)."

How to verify - mandatory

  1. Its pure textual you can just look at it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.372% when pulling 464401d on MouseZero:master into f701abe on sinonjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.372% when pulling 464401d on MouseZero:master into f701abe on sinonjs:master.

@fatso83
Copy link
Contributor

fatso83 commented Mar 27, 2017

Been wanting to fix this, thanks!

@fatso83 fatso83 merged commit cdd9abe into sinonjs:master Mar 27, 2017
@h-cow
Copy link
Contributor Author

h-cow commented Mar 27, 2017

No Problem.

@mroderick
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants