Fix #1432: add details around expectations.withArgs behavior to docs #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatso83
requested changes
Jul 28, 2017
There was a problem hiding this comment.
You did a bit too much :-) Basically, don't touch anything in _releases - change the source for upcoming releases
|
Thanks @fatso83, my mistake - updated |
fatso83
approved these changes
Jul 28, 2017
|
Thank you! |
franck-romano
pushed a commit
to franck-romano/sinon
that referenced
this pull request
Oct 1, 2019
rkaw92
added a commit
to rkaw92/warsawjs-workshop-50-unit-testing
that referenced
this pull request
Nov 16, 2020
This changes how the tests work as an example of behavior verification, as opposed to state verification. The third test is still not ported, see: sinonjs/sinon#1501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix issue #1432 - adds details to documentation of
expectationsmethodswithArgsandwithExactArgsto prevent confusion, such as #992How to verify
Probably not necessary to run the docs application - please review the copy and confirm whether it is clear, informative, etc, and whether I've touched the correct / necessary files.