Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Mochify 5 to run tests in Headless Chrome #1629

Merged
merged 6 commits into from
Dec 18, 2017
Merged

Upgrade to Mochify 5 to run tests in Headless Chrome #1629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6148f2
Upgrade to Mochify 5 to test in Headless Chrome
mantoni Dec 8, 2017
c0c6779
Prevent install scripts from running unnecessarily
mantoni Dec 8, 2017
93f422a
Use relative URLs in WebWorker test
mantoni Dec 8, 2017
07db0f4
Fix coverage test run
mantoni Dec 11, 2017
c1fd210
Remove headless test runs from CircleCI
mantoni Dec 14, 2017
b51d5b9
Run test-coverage script only once on Travis
mantoni Dec 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,17 @@ jobs:
name: Install dependencies
command: |
npm config set strict-ssl false
# Avoid downloading chromium unnecessarily
npm config set ignore-scripts true
npm install
npm config set ignore-scripts false
- run:
name: Pre-Test
# ESLint only supports Node >=4
command: |
if [[ ! "$(node --version)" =~ ^v4 ]]; then
NODE_VERSION=$(node --version)
if [[ ${NODE_VERSION:0:3} == "v6." ]]; then
npm run lint;
npm run test-headless;
npm run test-webworker;
fi
- run:
name: Test
Expand Down
7 changes: 5 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,12 @@ env:
before_install:
- npm config set strict-ssl false
- npm install coveralls
# Prevent mochify -> puppeteer install script to run unnecessarily
- if [ "x$TRAVIS_NODE_VERSION" != "x8" ]; then npm config set ignore-scripts true; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was new! Cool to know.


before_script:
# Make npm run work for the script phase:
- if [ "x$TRAVIS_NODE_VERSION" != "x8" ]; then npm config set ignore-scripts false; fi
# these build targets only need to run once per build, so let's conserve a few resources
# ESLint only supports Node >=4
- if [ "x$TRAVIS_NODE_VERSION" = "x8" ]; then npm run lint; fi
Expand All @@ -33,8 +37,7 @@ script:
- npm run test-node

after_success:
- npm run test-coverage
- cat ./coverage/lcov.info | coveralls lib
- if [ "x$TRAVIS_NODE_VERSION" = "x8" ]; then npm run test-coverage && cat ./coverage/lcov.info | coveralls lib; fi

git:
depth: 10
Loading