Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Use
nise.fakeServer
as the default sandboxserverPrototype
to fix #1534.Apparently the Chrome installation has changed and it is now necessary to pass the
--allow-chrome-as-root
flag on Travis like we already do on CircleCI.Background (Problem in detail) - optional
Creating a sandbox with fake server installed fake timers on the first XHR request. Both ways to install fake servers are affected:
and
Solution - optional
Setting
nise.fakeServer
as the defaultserverPrototype
on the sandbox fixes the issue.How to verify - mandatory
The new tests ensure the correct
serverPrototype
is used and the fake server returned byuseFakeServer()
is not an instance offakeServerWithClock
anymore.Checklist for author
npm run lint
passes