-
-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document fake timer *Async() methods #2055
Conversation
Pull Request Test Coverage Report for Build 2912
💛 - Coveralls |
Very nice! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I still have to make an update to this based on sinonjs/fake-timers#237 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you for doing this.
As stated in sinonjs/fake-timers#237, it would be nice with a little caveat on what to expect from runAllAsync
, but it's not a blocker.
bfd3525
to
6c39c3a
Compare
|
As soon as we bump the version number for Lolex and the version used in Sinon, I guess we should merge this. Right? |
Yeah, I suppose so. Not sure what's the release process here. Possibly this can be merged into whatever PR does the Lolex bumping? |
sinon@8 is now out - this can probably now get merged? |
@dominykas thanks! Once we cut the next release, this will be visible on the site. |
Purpose (TL;DR) - mandatory
Adds documentation for new
lolex
features, introduced in sinonjs/fake-timers#105 (and its 2019 version: sinonjs/fake-timers#237)This needs to stay a draft until the relevant functionality from
lolex
is merged, but feedback is most welcome.How to verify - mandatory
https://github.com/sinonjs/sinon/blob/master/docs/CONTRIBUTING.md
Checklist for author
npm run lint
passes