Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lolex (and Nise) for new async timer methods #2159

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Nov 20, 2019

Purpose (TL;DR) - mandatory

Updates Lolex for new async methods made by @kylefleming
(async versions of all timer-executing calls).

Background (Problem in detail) - optional

See sinonjs/fake-timers#105 (repackaged as sinonjs/fake-timers#237)

The goal of these functions is to provide those
writing tests with tools to test code that uses
promises without having to work around the fact
that lolex executes all timers synchronously in a row.

How to verify - mandatory

  1. npm install && npm test
  2. Try to use some of the new methods from Lolex

@fatso83 fatso83 merged commit 07aa4a1 into sinonjs:master Dec 3, 2019
@fatso83 fatso83 deleted the update-pkgs branch December 3, 2019 14:38
@mroderick
Copy link
Member

I guess this will go into the next semver:major, which will be a very nice upgrade 👍

@fatso83
Copy link
Contributor Author

fatso83 commented Dec 3, 2019

It's not breaking, though. Just wanted to signal that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants