Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid return and callArg* clearing each other's state #2593

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Avoid return and callArg* clearing each other's state #2593

merged 3 commits into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. Add regression test for #2572

    @fatso83
    fatso83 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    09b4da5 View commit details
    Browse the repository at this point in the history

  2. Partially revert "fix returns does not override call through (#2567)" 

    This partially reverts commit 5fde5ae:
- we keep the tests
- revert to the old manual clearing of props

The clearing of callThrough has then been manually added to what I
deem are the relevant spots. Tests are unaltered.
    @fatso83
    fatso83 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f4fb595 View commit details
    Browse the repository at this point in the history

  3. Add reflected test and fixup test titles

    @fatso83
    fatso83 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    90f80a5 View commit details
    Browse the repository at this point in the history