Close #458 by proving that there is no failure #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea to have a test file for issues. Can you fix the quotes in the test implementation? |
This pull request closes issue sinonjs#458 by implementing a test that shows that it is possible to stub fs.readFileSync. I've run the tests on node 0.10.25 and 0.10.29 and cannot reproduce the bug.
|
@mantoni quotes fixed (my fingers have gotten used to single quotes) |
mantoni
added a commit
that referenced
this pull request
Aug 1, 2014
Close #458 by proving that there is no failure
|
The reason that you cannot recreate is because you are running on Node (i.e. JS). The issue only happens when runnignvia CoffeeScript. I have submitted a pull request, which run the test in coffeescript and fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes issue #458 by implementing a test that shows that it is possible to stub fs.readFileSync.
I've run the tests on node 0.10.25 and 0.10.29 and cannot reproduce the bug.