Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on setuptools #66

Closed
albertvaka opened this issue Jan 30, 2024 · 2 comments
Closed

Missing dependency on setuptools #66

albertvaka opened this issue Jan 30, 2024 · 2 comments

Comments

@albertvaka
Copy link

albertvaka commented Jan 30, 2024

setuptools is no longer installed by default in python 3.12: python/cpython#101039

_sinricpro_websocket.py depends on it, causing this exception if not installed:

 File ".../_sinricpro_websocket.py", line 16, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

It should be added as an explicity dependency.

@albertvaka
Copy link
Author

Alternatively, since pkg_resources is also deprecated, we could depend on importlib_metadata instead and change the code to:

version = importlib_metadata.version("sinricpro")

@kakopappa
Copy link
Contributor

Hi @albertvaka

Thanks for letting us know. Haven't looked into 3.12.

Hey @cojmeister are you still working on the PR #65 ? If there's nothing else I can I can merge the PR and can take a look at upgrading the master codebase to 3.12.

kakopappa added a commit that referenced this issue Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants