Only use 'localhost' replacement for 127.0.0.1 #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As was discussed in issue #558, as Harp is now it is not possible to distinguish between an instance listening on localhost and any ip. This change fixes that. Also adds tests to confirm behavior
|
Note that this is reopening of #578, as requested. I don't use harp anymore, so I couldn't extensively test this, but it's a pretty focused straight-forward change and I've added a couple tests to confirm functionality. |
|
I have to say it's pretty disheratening to be asked to resubmit a PR only to have it ignored a second time. I spent my free time on this, the second time around to try and better a project I don't even use anymore. Please don't solicit work if you are just going to ignore, it's a waste of both of our time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was discussed in issue #558, as Harp is now it is not possible
to distinguish between an instance listening on localhost and
any ip. This change fixes that.
Also adds tests to confirm behavior.