Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump jade version #115

Merged
merged 1 commit into from
Jan 14, 2016
Merged

bump jade version #115

merged 1 commit into from
Jan 14, 2016

Conversation

lunelson
Copy link
Contributor

Updated jade to current version; fixes #114

All tests are passing except the one where it should warn against use of !!! rather than doctype; weird, cause I know there are a bunches of issues there. Maybe it's been undone?

@kennethormandy
Copy link
Collaborator

We use a fork of Jade with the patch to warn rather than fail on !!! merged: https://github.com/harp/jade

If you want to open a PR with their upstream changes merged there, we’d accept that. Sadly it looks more complicated this time than just git pull upstream master.

We’re also dropping Node v0.10.x support in the next release, though, so if @sintaxi isn’t bothered either, I think enough time has passed we’d be fine dropping our fork and going back to the main version and dropping !!!.

@lunelson
Copy link
Contributor Author

Ah, ok I get it, the warning is in your fork. I agree it's going to be too complicated to try to merge the upstream changes; options would be to re-fork the current jade and patch that to warn instead of fail, or as you say just drop the fork and let !!! fail.

Dropping old Node support may be a breaking change for some users anyway so that seems like a reasonable time to do it

@kennethormandy kennethormandy modified the milestone: v1.0.0 Jan 6, 2016
@kennethormandy kennethormandy mentioned this pull request Jan 7, 2016
6 tasks
@sintaxi sintaxi merged commit b7072dd into sintaxi:master Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jade 'block unbuffered code' syntax fails—update Jade?
3 participants