Warning API or update Jade and corresponding tests for 1.0.2 #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jade deprecated
!!!
fordoctype
in 1.0.0, which is unfortunate. It was also decided not to make it a warning, like withscript.
, but to actually throw an error.I don’t necessarily think this should get merged, but we’ll have to deal with it at some point. It’s going to break every app written in Jade since we were advocating the
!!!
shorthand overdoctype
(I didn’t even know that was shorthand, to be honest).If anything, it might indicate we need some way to throw our own warning pages, just like we do for errors. Then, when breaking API changes happen again, either in Harp like with
_data
, or in the preprocessors, like when LESS stopped working with Bootstrap 2 one, this issue, or whatever else, Harp could fail more gracefully. It would actually also be great for missing libsass features, too.