-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LBFGS implementation #106
LBFGS implementation #106
Conversation
Port of MRST code originally written by Stein. Port was done by Junjian with some cleanup by Olav, licensed under MIT in agreement with all contributors. Co-Authored-By: Stein Krogstad <stein.krogstad@sintef.no> Co-Authored-By: JUNJIAN-LI-CUPB <153202025+junjian-li-cupb@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 45.64% 45.96% +0.32%
==========================================
Files 140 145 +5
Lines 15599 16295 +696
==========================================
+ Hits 7120 7490 +370
- Misses 8479 8805 +326 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only two minor suggestions
No description provided.