Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBFGS implementation #106

Merged
merged 7 commits into from
Nov 20, 2024
Merged

LBFGS implementation #106

merged 7 commits into from
Nov 20, 2024

Conversation

moyner
Copy link
Member

@moyner moyner commented Nov 19, 2024

No description provided.

moyner and others added 5 commits November 19, 2024 12:20
Port of MRST code originally written by Stein. Port was done by Junjian with some cleanup by Olav, licensed under MIT in agreement with all contributors.

Co-Authored-By: Stein Krogstad <stein.krogstad@sintef.no>
Co-Authored-By: JUNJIAN-LI-CUPB <153202025+junjian-li-cupb@users.noreply.github.com>
@moyner moyner requested a review from steink November 19, 2024 12:53
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 69.10755% with 135 lines in your changes missing coverage. Please review.

Project coverage is 45.96%. Comparing base (11e27bd) to head (4bdb2bc).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
src/LBFGS/constrained_optimizer.jl 66.47% 116 Missing ⚠️
src/LBFGS/limited_memory_hessian.jl 78.57% 18 Missing ⚠️
src/simulator/optimization.jl 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   45.64%   45.96%   +0.32%     
==========================================
  Files         140      145       +5     
  Lines       15599    16295     +696     
==========================================
+ Hits         7120     7490     +370     
- Misses       8479     8805     +326     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@steink steink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only two minor suggestions

src/LBFGS/constrained_optimizer.jl Outdated Show resolved Hide resolved
src/LBFGS/constrained_optimizer.jl Outdated Show resolved Hide resolved
@moyner moyner merged commit ef0fa51 into main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants