Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface of SigPro w/pipelines and primitives #54

Merged
merged 51 commits into from
Jan 31, 2024

Conversation

andyx13
Copy link
Collaborator

@andyx13 andyx13 commented Jan 13, 2024

Larger update:

Additional modifications:

@andyx13 andyx13 linked an issue Jan 21, 2024 that may be closed by this pull request
@andyx13
Copy link
Collaborator Author

andyx13 commented Jan 21, 2024

Made an additional slight modification to add a primitive_inputs argument. This is necessary so as to not break the FrequencyBand primitive, which has a non-standard input argument.

@andyx13 andyx13 marked this pull request as ready for review January 21, 2024 08:53
@andyx13 andyx13 added this to the 0.1.3 milestone Jan 23, 2024
Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort @andyx13! There are minor comments overall, and some improvements to be made to the pipeline initialization.

HISTORY.md Outdated Show resolved Hide resolved
sigpro/basic_primitives.py Outdated Show resolved Hide resolved
sigpro/basic_primitives.py Outdated Show resolved Hide resolved
sigpro/primitive.py Outdated Show resolved Hide resolved
sigpro/primitive.py Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Show resolved Hide resolved
@andyx13 andyx13 linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @andyx13! Few comments to improve readability of the code.

I also noticed that the unittests are missing cases where the pipeline would raise an error. I think it would be good to include these cases as well!

sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
sigpro/pipeline.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged! Great work @andyx13!

@andyx13 andyx13 merged commit 5e16aaa into master Jan 31, 2024
48 checks passed
@andyx13 andyx13 deleted the interface_pipeline_update branch January 31, 2024 21:52
@sarahmish sarahmish mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants