Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipPomModules/packagingSupporteds not working #128

Closed
gunnarmorling opened this issue Mar 16, 2016 · 4 comments
Closed

skipPomModules/packagingSupporteds not working #128

gunnarmorling opened this issue Mar 16, 2016 · 4 comments

Comments

@gunnarmorling
Copy link

I'd like to configure japicmp in the root POM of my multi-module Maven project. Of course, no report is needed for the root module itself. Two settings seem to be provided to help with that:

skipPomModules>true</skipPomModules>
<packagingSupporteds>
    <packagingSupported>jar</packagingSupported>
</packagingSupporteds

Unfortunately though, both don't take any affect, i.e. the plug-in is still run for the root module, resulting in an exception about the JAR file of that module missing (which is natural, as it has POM packaging). I took a quick look in the debugger and the mavenProject injected into the Mojo is null, resulting in an early return from the filter method.

Any idea why that could be the case?

@siom79
Copy link
Owner

siom79 commented Mar 17, 2016

mavenProject is injected by the container, so I don't know why it should be null.

Which maven version are you using? Is there an example that reproduces this behavior?

@siom79
Copy link
Owner

siom79 commented May 14, 2016

Cannot reproduce.

@siom79 siom79 closed this as completed May 14, 2016
@gunnarmorling
Copy link
Author

Sorry for the radio silence, kind of forgot about this one.

I'm on Maven 3.3.3 @ OS X. That's the project where I noticed this behavior: https://github.com/hibernate/hibernate-search/blob/master/pom.xml.

siom79 added a commit that referenced this issue May 14, 2016
@siom79
Copy link
Owner

siom79 commented May 14, 2016

Could reproduce with Maven 3.3.3 @ Ubuntu 14.04. You defined the plugin within the <reporting/> block of the root pom with packaging type pom. In this case the injected value for mavenProject was not properly propagated. Fixed this on the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants