Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes NPE in JavadocLikePackageFilter when matching against classes in the default (empty) package #106

Closed
wants to merge 1 commit into from

Conversation

ntherning
Copy link
Contributor

Without this patch I get an NPE like this:

Execution of JApiCmp failed: null
java.lang.NullPointerException
    at java.util.regex.Matcher.getTextLength(Matcher.java:1283)
    at java.util.regex.Matcher.reset(Matcher.java:309)
    at java.util.regex.Matcher.<init>(Matcher.java:229)
    at java.util.regex.Pattern.matcher(Pattern.java:1093)
    at japicmp.filter.JavadocLikePackageFilter.matches(JavadocLikePackageFilter.java:29)
    at japicmp.filter.Filters.includeClass(Filters.java:63)
    at japicmp.cmp.JarArchiveComparator.applyFilter(JarArchiveComparator.java:190)
    at japicmp.cmp.JarArchiveComparator.compareClassLists(JarArchiveComparator.java:171)
    at japicmp.cmp.JarArchiveComparator.createAndCompareClassLists(JarArchiveComparator.java:153)
    at japicmp.cmp.JarArchiveComparator.compare(JarArchiveComparator.java:67)
    at japicmp.cli.JApiCli$Compare.run(JApiCli.java:77)
    at japicmp.JApiCmp.main(JApiCmp.java:16)

when invoking japicmp with an include pattern and the JAR files contain classes in the default package.

@siom79
Copy link
Owner

siom79 commented Jan 9, 2016

Merged pull request to develop branch.

@siom79 siom79 closed this Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants