Fix for issue #359 - >=0.16.0: Cannot compare versions because the number of old versions is different than the number of new versions #381
Conversation
| @@ -296,7 +296,6 @@ public List<CtClass> filterClasses(List<CtClass> ctClasses, ReducibleClassPool c | |||
| LOGGER.fine(String.format("Adding class '%s' with jar name '%s' to list.", ctClass.getName(), ctClass.getName())); | |||
| } | |||
| } else { | |||
| classPool.remove(ctClass); | |||
There was a problem hiding this comment.
I don't think this is necessary. The issue is about old code that no longer is called / has been removed.
There was a problem hiding this comment.
Using 0.18.5 we get error: Execution default-cli of goal com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp failed: Could not load 'com.....C***': com.....C***. Please make sure that all libraries have been added to the classpath (CLASSPATH=:/r***...:) or try the option '--ignore-missing-classes'.
After removing above line it starts to work again. Please check.
There was a problem hiding this comment.
Do you have a concrete example to reproduce? The message Please make sure that all libraries have been added to the classpath ... is normally printed when the class is NOT on the classpath. It would be an error if it actually is on the classpath; hence, I would need a concrete example.
There was a problem hiding this comment.
Btw: The code here filters the classes by the configured filters. Are you sure that there is not filter configured, that excludes the mentioned class?
Issue was created in pull: #333
It causes to not work correctly in some cases in big, multi module projects. Case was described by @martinaldrin in #359.
Issue can be solved by changing on line as is was before pull #333. Please review @siom79, and consider merging and deploying, for now we are blocked and we cannot go over version 0.15.6 in our projects.