Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download fails when a temporary distribution archive exists #101

Closed
v1nc3n4 opened this issue Apr 19, 2020 · 0 comments
Closed

Download fails when a temporary distribution archive exists #101

v1nc3n4 opened this issue Apr 19, 2020 · 0 comments
Assignees
@v1nc3n4
Labels
Bug Something is not working as expected
Milestone
2.1.0

Comments

@v1nc3n4
Copy link
Member

v1nc3n4 commented Apr 19, 2020 •
edited
Loading

Actual behaviour: after a installNode task or installYarn task fails, the distribution archive that may have been opened in the temporary directory to write the downloaded data is closed but not removed. Consequently, the following task executions fail because the distribution file already exists, but overwrite is not supported by the plugin.

Expected behaviour: whatever the previous task outcome, if a distribution file exists, it is overwritten.
@v1nc3n4 v1nc3n4 added the Bug Something is not working as expected label Apr 19, 2020
@v1nc3n4 v1nc3n4 added this to the 2.1.0 milestone Apr 19, 2020
@v1nc3n4 v1nc3n4 self-assigned this Apr 19, 2020
@v1nc3n4 v1nc3n4 changed the title Download fails when a previous distribution archive exists Download fails when a temporary distribution archive exists Apr 19, 2020
@v1nc3n4 v1nc3n4 added the IN PROGRESS Design and implementation are in progress label Apr 20, 2020
v1nc3n4 added a commit that referenced this issue Apr 20, 2020
@v1nc3n4
Fixed #101
9e03533
@v1nc3n4 v1nc3n4 removed the IN PROGRESS Design and implementation are in progress label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v1nc3n4 v1nc3n4

Labels
Bug Something is not working as expected
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@v1nc3n4