Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path /bin/sh instead of relying on the PATH environment variable. #125

Closed
v1nc3n4 opened this issue Aug 5, 2020 · 0 comments
Assignees
Labels
Bug Something is not working as expected
Milestone

Comments

@v1nc3n4
Copy link
Member

v1nc3n4 commented Aug 5, 2020

Actually, if the sh command is not accessible through the PATH environment variable, or if another executable with the same name has priority in the environment variable, running any frontend script would fail: the shell would not be found, which is required to launch node/npm/npx/yarn executables in a dedicated shell process.

To avoid such - very rare - case, the plugin must rely on the absolute path /bin/sh.

This issue was identified after a build under Travis with Ubuntu Bionic failed for this exact reason: the sh command was not found using the PATH environment variable.

@v1nc3n4 v1nc3n4 self-assigned this Aug 5, 2020
@v1nc3n4 v1nc3n4 added the Bug Something is not working as expected label Aug 5, 2020
@v1nc3n4 v1nc3n4 added this to the 3.0.1 milestone Aug 5, 2020
v1nc3n4 added a commit that referenced this issue Aug 5, 2020
v1nc3n4 added a commit that referenced this issue Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant