Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use system properties for HTTP proxy configuration #136

Closed
v1nc3n4 opened this issue Nov 5, 2020 · 2 comments
Closed

Use system properties for HTTP proxy configuration #136

v1nc3n4 opened this issue Nov 5, 2020 · 2 comments
Assignees
@v1nc3n4
Labels
Feature Request of a new feature or a behaviour change
Milestone
5.0.0

Comments

@v1nc3n4
Copy link
Member

v1nc3n4 commented Nov 5, 2020

As suggested by @jorgheymans in issue #131, the plugin could use system properties to configure HTTP proxying of the download requests.

The default value for proxyHost, proxyPort, proxyUsername, proxyPassword would be taken respectively from http.proxyHost, http.proxyPort, http.proxyUser, http.proxyPassword.
@v1nc3n4 v1nc3n4 added the Feature Request of a new feature or a behaviour change label Nov 5, 2020
@v1nc3n4 v1nc3n4 self-assigned this Nov 5, 2020
@v1nc3n4 v1nc3n4 added this to the 4.1.0 milestone Nov 5, 2020
@jorgheymans
Copy link

You should probably take into account the https variant also, and the nonProxyHosts for both cases as well to be complete e.g. https://medium.com/@petehouston/execute-gradle-behind-a-corporate-proxy-network-509260961813

@v1nc3n4
Copy link
Member Author

v1nc3n4 commented Nov 5, 2020 •
edited
Loading

Yes, indeed, thank you.

@v1nc3n4 v1nc3n4 added the IN PROGRESS Design and implementation are in progress label Nov 7, 2020
v1nc3n4 added a commit that referenced this issue Jan 8, 2021
@v1nc3n4
Fixed #136
59d5d95
@v1nc3n4 v1nc3n4 removed the IN PROGRESS Design and implementation are in progress label Jan 8, 2021
v1nc3n4 added a commit that referenced this issue Jan 8, 2021
@v1nc3n4
Fixed #136
74022b4
v1nc3n4 added a commit that referenced this issue Jan 15, 2021
@v1nc3n4
Fixed #134, #136, #141, #145 (#146)
3962652 
* Fixed #134

* Fixed #141

* Fixed #136

* Fixed #145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v1nc3n4 v1nc3n4

Labels
Feature Request of a new feature or a behaviour change
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@jorgheymans @v1nc3n4