Add ci workflow columns in readme #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sip-21
force-pushed
the
add-ci-workflow-columns-in-readme
branch
from
979d30f to
b9d0b51
Compare
chrisguida
reviewed
Mar 16, 2024
.github/workflows/nightly.yml
Outdated
| @@ -91,7 +91,7 @@ jobs: | |||
| export CLN_PATH=${{ github.workspace }}/lightning | |||
| pip3 install --upgrade pip | |||
| pip3 install --user -U virtualenv pip > /dev/null | |||
| python3 .ci/test.py | |||
| python3 .ci/test.py nightly true | |||
There was a problem hiding this comment.
Can we change true to something more descriptive?
Perhaps badges-true
There was a problem hiding this comment.
I turned it into a boolean flag --update-badges
sip-21
force-pushed
the
add-ci-workflow-columns-in-readme
branch
2 times, most recently
from
a36a1fc to
4dd5782
Compare
|
Please add description and squash |
sip-21
force-pushed
the
add-ci-workflow-columns-in-readme
branch
from
5969fdc to
782d854
Compare
sip-21
force-pushed
the
add-ci-workflow-columns-in-readme
branch
from
782d854 to
ea70648
Compare
@chrisguida I guess you saw my PR here: lightningd#509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.