[wip] fix various bazel incompatibilities #404
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to bazel to fix various incompatibilities from upgrading to version 0.28
Some API changes happened. handled by patching
zip_file
bugfix in bazel exposes a minor error in one of our BUILD files, fixed
rules_go no longer declares some modules we were using, so we import those ourselves
However, the big problem is changes around python 2/3 version:
problem with pkg_deb, can be partially solved by migrating to rules_pkg 0.2.0's
pkg_deb
(see bazelbuild/bazel#8489):however, there's a python3 bug in containerregistry (which seems kinda poorly maintained) which isn't yet fixed. (and doesn't have any sign of being fixed soon)
And the new fix for rules_pkg fails to be python2 compatible:
So I downgraded rules_pkg back to 0.1.0 and forced python 2 for now. (Which is also what rules_k8s did, see bazelbuild/rules_k8s#305)
However, we hit another containerregistry bug which I don't understand. Didn't check if it occurs with previous version of bazel yet.
There's probably other python 2/3 bugs that I didn't hit because I couldn't get past the containerregistry one.
Checklist: