Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sophisticated regex to detect limited enrollment #143

Merged
merged 10 commits into from
Feb 4, 2025

Conversation

duck-master
Copy link
Contributor

Exactly what it says on the tin.

I also added a file called text_mining.py which searches the dataset for sentences in course descriptions that contain certain keywords. This will probably be useful if the regex needs to be updated.

@dtemkin1 dtemkin1 requested review from psvenk and dtemkin1 February 4, 2025 00:57
Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks!

Copy link
Collaborator

@dtemkin1 dtemkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Compared the old generated catalog.json with a new one and it seemed more accurate, thanks for this!

@dtemkin1 dtemkin1 merged commit aea1d04 into sipb:main Feb 4, 2025
4 checks passed
@duck-master duck-master deleted the limitedregex branch February 4, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants