Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsc and build to CI #90

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Add tsc and build to CI #90

merged 6 commits into from
Dec 3, 2024

Conversation

psvenk
Copy link
Member

@psvenk psvenk commented Dec 2, 2024

No description provided.

@psvenk psvenk requested a review from dtemkin1 December 2, 2024 20:47
react-scripts prevents us from depending on tsc 5.x, but we need to use
tsc 5.x for type checking so that "moduleResolution": "bundler" is
supported; use npx to run the latest tsc in CI.
This is the earliest version that will properly type check the code
(because of the module issues); we don't want to use a newer version
since we want to reject syntax that isn't valid in TypeScript 4. (We
can't do anything to reject syntax that was introduced in 5.0.0.)
Copy link
Collaborator

@dtemkin1 dtemkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, once we can get the version of typescript updated (after we move off CRA) we should switch to using the version specified in package.json, just putting this here so we both remember

@psvenk psvenk merged commit 91d1f32 into main Dec 3, 2024
3 checks passed
@psvenk psvenk deleted the ci branch December 3, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants