Add support for connecting to multiple LDAP hosts #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace-separated host strings This update enhances the LDAP client by allowing it to connect to multiple LDAP servers. The 'Host' field now accepts a space-separated string of LDAP host addresses. The `Connect` method iterates over these hosts, attempting to establish a connection with each one until a successful connection is made. Key changes: - Split the 'Host' field into individual host addresses. - Iterated over each host to attempt a connection. - Implemented error handling to try the next host if a connection fails. - Updated the connection logic to support both non-SSL and SSL connections, including handling TLS upgrades. This change improves the robustness of the LDAP client by ensuring that the application can failover to another LDAP server if the primary server is unavailable.
|
Nausherwan Khan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thank you! Looks good for me |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Reconnect with TLS | ||
| if !lc.SkipTLS { | ||
| err = l.StartTLS(&tls.Config{InsecureSkipVerify: true}) |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pace-separated host strings
This update enhances the LDAP client by allowing it to connect to multiple LDAP servers. The 'Host' field now accepts a space-separated string of LDAP host addresses. The
Connectmethod iterates over these hosts, attempting to establish a connection with each one until a successful connection is made.Key changes:
This change improves the robustness of the LDAP client by ensuring that the application can failover to another LDAP server if the primary server is unavailable.