Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables optional handling of PKCE #569

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

edgar89
Copy link

@edgar89 edgar89 commented Oct 2, 2024

Some OAuth provider do not have support for PKCE. This PR uses a feature flag to use/not use PKCE-specific fields during OAuth process.

Default is the current behaviour where PKCE is enabled

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

@lmangani
Copy link
Member

lmangani commented Oct 2, 2024

Thanks for the contribution @edgar89 we appreciate it!
Please sign the CLA so we can review and merge the change 👍

@edgar89
Copy link
Author

edgar89 commented Oct 2, 2024

Thanks for the contribution @edgar89 we appreciate it! Please sign the CLA so we can review and merge the change 👍

Hello @lmangani I think I did that, I don't know why it is still reported as unsigned

image

@lmangani
Copy link
Member

lmangani commented Oct 2, 2024

Hello @lmangani I think I did that, I don't know why it is still reported as unsigned

Thanks @edgar89 are you sure its the same email used for the commits was used to sign the CLA?

@skyreginag
Copy link
Contributor

Hello @lmangani I think I did that, I don't know why it is still reported as unsigned

Thanks @edgar89 are you sure its the same email used for the commits was used to sign the CLA?

Yeah, sorry about that - I commited using company account and opened the PR using my personal account. Now it should be all ok

@lmangani
Copy link
Member

lmangani commented Oct 2, 2024

Thank you Giuseppe @edgar89
@adubovikov please review and merge 👍

controller/v1/user.go Outdated Show resolved Hide resolved
@adubovikov
Copy link
Member

Thank you!

@adubovikov adubovikov merged commit 86e89e2 into sipcapture:master Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants