Buttons #14
Merged
Buttons #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Me: "I'm going to make a consistent UI library with Figma and SCSS" Also me: *Derails entirely from the Figma design without even thinking about it*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our very first component (in CSS). 🤩
So uhm, I already do realize that this is a bit of a deviation from the design shown in #6. The inspiration for these buttons comes from various sources, including Primer, Tailwind, and Bootstrap.
They include both contextual variants (like
primary,danger) and color variants (likeblue,red). Whether the later will survive until the end will remain to be seen.This is also the first pull request where we'll really have to start paying attention to contrast ratios and automate the color of text based on the background it appears on.
Checklist
:hover,:focus, and:active(and.active)aria-disabled,disabled, and.disabledDocumentation
See the included documentation for more information.