Skip to content

Commit

Permalink
Fixed broken links.
Browse files Browse the repository at this point in the history
  • Loading branch information
sipsorcery committed Dec 22, 2024
1 parent ed9a387 commit a68546d
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 7 deletions.
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ Test run at 2024-12-21 22:16:22.531491

If you are interested in adding a library to this project the recommended steps are listed below. The steps don't necessarily have to be completed in any specific order.

- Write a Peer Connection Test Client application according to the [specification](doc/EchoTestSpecification.md#client-peer-operation) or base it off an [existing application](doc/EchoTestSpecification.md#view-the-code).
- Write a Peer Connection Test Client application according to the [specification](doc/PeerConnectionTestSpecification.md#client-peer-operation) or base it off an [existing application](doc/PeerConnectionTestSpecification.md#view-the-code).

- Test your client by building and running one of the [Peer Connection Test Servers](https://github.com/sipsorcery/webrtc-echoes/blob/master/doc/EchoTestSpecification.md#view-the-code) or you can use one of the [Peer Connection Test Server Docker Images](https://github.com/sipsorcery?tab=packages&q=webrtc):
- Test your client by building and running one of the [Peer Connection Test Servers](doc/PeerConnectionTestSpecification.md#view-the-code) or you can use one of the [Peer Connection Test Server Docker Images](https://github.com/sipsorcery?tab=packages&q=webrtc):

````
docker run -it --rm --init -p 8080:8080 ghcr.io/sipsorcery/aiortc-webrtc-echo
Expand All @@ -82,4 +82,12 @@ docker run -it --rm --init -p 8080:8080 ghcr.io/sipsorcery/werift-webrtc-echo

- Repeat the process for a [Peer Connection Test Server](doc/PeerConnectionTestSpecification.md#server-peer-operation).

- Servers can also be tested with docker images:

````
docker run --entrypoint "/client.sh" ghcr.io/sipsorcery/pion-webrtc-echo http://host.docker.internal:8080/offer
docker run --entrypoint "/client.sh" ghcr.io/sipsorcery/sipsorcery-webrtc-echo http://host.docker.internal:8080/offer
etc...
````

- Create a [Dockerfile](doc/EchoTestDockerRequirements.md) and add a Pull Request for it so your Peer Connection Test application(s) can be included in the automated testing.
2 changes: 2 additions & 0 deletions libwebrtc/PcFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ PcFactory::PcFactory() :
_pcf_deps.event_log_factory = std::make_unique<webrtc::RtcEventLogFactory>(_pcf_deps.task_queue_factory.get());
_pcf_deps.audio_encoder_factory = webrtc::CreateBuiltinAudioEncoderFactory();
_pcf_deps.audio_decoder_factory = webrtc::CreateBuiltinAudioDecoderFactory();
//_pcf_deps.video_encoder_factory = webrtc::CreateBuiltinVideoEncoderFactory(); // Missing symbol in m132 build (tried everything).
//_pcf_deps.video_decoder_factory = webrtc::CreateBuiltinVideoDecoderFactory(); // Missing symbol in m132 build (tried everything).
_pcf_deps.adm = rtc::scoped_refptr<webrtc::AudioDeviceModule>(FakeAudioCaptureModule::Create());
_pcf_deps.audio_processing = apm; // Gets moved in EnableMedia.

Expand Down
2 changes: 1 addition & 1 deletion libwebrtc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ src$ gclient sync --force
And then:

````
src$ gn gen out/Default --args="is_component_build=false use_custom_libcxx=false use_custom_libcxx_for_host=false rtc_enable_protobuf=false"
src$ gn gen out/Default --args="use_custom_libcxx=false"
src$ gn args out/Default --list --short --overrides-only
src$ ninja -C out/Default
src$ out/Default/webrtc_lib_link_test
Expand Down
8 changes: 4 additions & 4 deletions sipsorcery/server/Program.cs
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ public WebRTCEchoServer(List<IPAddress> presetAddresses)

public async Task<RTCPeerConnection> GotOffer(RTCSessionDescriptionInit offer)
{
logger.LogTrace($"SDP offer received.");
logger.LogTrace(offer.sdp);
logger.LogDebug($"SDP offer received.");
logger.LogDebug(offer.sdp);

var pc = new RTCPeerConnection();

Expand Down Expand Up @@ -253,8 +253,8 @@ public async Task<RTCPeerConnection> GotOffer(RTCSessionDescriptionInit offer)
var answer = pc.createAnswer();
await pc.setLocalDescription(answer);

logger.LogTrace($"SDP answer created.");
logger.LogTrace(answer.sdp);
logger.LogDebug($"SDP answer created.");
logger.LogDebug(answer.sdp);

return pc;
}
Expand Down

0 comments on commit a68546d

Please sign in to comment.