added code to handle the break command sent by GRBL once serial conne… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction is established.
|
One clarification... I am using GRBL 1.1 on a CNC xPro V3 controller. Unsure if the break is unique to GRBL or just this revision. |
sir-buckyball
requested changes
Dec 31, 2017
| @@ -230,8 +230,12 @@ app.service('machineService', function($rootScope, $timeout, warningService) { | |||
|
|
|||
| // Log errors | |||
| chrome.serial.onReceiveError.addListener(function(info) { | |||
| if (info.error === "break") { | |||
| chrome.serial.setPaused(info.connectionId, false, function() {}); | |||
| } else { | |||
| warningService.warn("connection", "error with serial communication: " + info.error); | |||
There was a problem hiding this comment.
nit: Please indent this block you've surrounded.
| @@ -230,8 +230,12 @@ app.service('machineService', function($rootScope, $timeout, warningService) { | |||
|
|
|||
| // Log errors | |||
| chrome.serial.onReceiveError.addListener(function(info) { | |||
| if (info.error === "break") { | |||
| chrome.serial.setPaused(info.connectionId, false, function() {}); | |||
There was a problem hiding this comment.
I think it would be appropriate to still log the error to the console so it's clear that this condition is being encountered in the logs. See line 21 for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRBL firmware seems to issue a serial break once the connection is established. This would leave the chrome serial service in a paused state. By simply unpausing the serial service, grbl firmware continues to work as expected.