Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to match Ember CLI 1.5.0 with contentFor options. #6

Merged
merged 9 commits into from
Jan 1, 2015

Conversation

sir-dunxalot
Copy link
Owner

This PR enables the addon to make use of the new {{content-for}} hooks introduced in Ember CLI 1.4.0. Specifically:

{{content-for 'head-footer'}}
{{!-- And --}}
{{content-for 'body-footer'}}

This is done through the addition of two new options that can be customizes in your app's Brocfile:

// Ember CLI less than v1.4.0
var app = new EmberApp({
  emberCliConcat: {
    scriptsContentFor: 'body-footer'
    stylesContentFor: 'head-footer'
  }
});

Apps using Ember CLI 1.3 or lower will have to change these default values:

// Ember CLI less than v1.4.0
var app = new EmberApp({
  emberCliConcat: {
    scriptsContentFor: 'body'
    stylesContentFor: 'head'
  }
});

@sir-dunxalot
Copy link
Owner Author

The Readme index.html examples need updating before this is merged in.

sir-dunxalot pushed a commit that referenced this pull request Jan 1, 2015
- Upgraded to match Ember CLI 1.5.0 with contentFor options
- Exposed options to customize contentFor blocks
- Moved Documentation to wiki
- Added basic test
@sir-dunxalot sir-dunxalot merged commit 1e960e9 into master Jan 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant