Add arrow function support

README.md

@@ -12,7 +12,7 @@ Plugin for PHP_CodeSniffer static analysis tool that adds analysis of problemati
 
 ### Requirements
 
-VariableAnalysis requires PHP 5.6 or higher and [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) version 3.1.0 or higher.
+VariableAnalysis requires PHP 5.6 or higher and [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) version 3.5.0 or higher.
 
 It also requires [PHPCSUtils](https://phpcsutils.com/) which must be installed as a PHPCS standard. If you are using composer, this will be done automatically (see below).
 

Tests/VariableAnalysisSniff/ArrowFunctionTest.php

@@ -0,0 +1,60 @@
+<?php
+namespace VariableAnalysis\Tests\VariableAnalysisSniff;
+
+use VariableAnalysis\Tests\BaseTestCase;
+
+class ArrowFunctionTest extends BaseTestCase {
+  public function testArrowFunctions() {
+    $fixtureFile = $this->getFixture('ArrowFunctionFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->ruleset->setSniffProperty(
+      'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
+      'allowUnusedParametersBeforeUsed',
+      'true'
+    );
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [
+      9,
+      14,
+      19,
+      24,
+      30,
+      34,
+      51,
+      57,
+      61,
+      67,
+      71,
+    ];
+    $this->assertEquals($expectedWarnings, $lines);
+  }
+
+  public function testArrowFunctionsWithoutUnusedBeforeUsed() {
+    $fixtureFile = $this->getFixture('ArrowFunctionFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->ruleset->setSniffProperty(
+      'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
+      'allowUnusedParametersBeforeUsed',
+      'false'
+    );
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [
+      9,
+      14,
+      19,
+      24,
+      30,
+      34,
+      39,
+      51,
+      57,
+      61,
+      63,
+      67,
+      71,
+    ];
+    $this->assertEquals($expectedWarnings, $lines);
+  }
+}

Tests/VariableAnalysisSniff/VariableArgumentListTest.php

@@ -0,0 +1,48 @@
+<?php
+namespace VariableAnalysis\Tests\VariableAnalysisSniff;
+
+use VariableAnalysis\Tests\BaseTestCase;
+
+class VariableArgumentListTest extends BaseTestCase {
+  public function testVariableArgumentList() {
+    $fixtureFile = $this->getFixture('VariableArgumentListFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->ruleset->setSniffProperty(
+      'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
+      'allowUnusedParametersBeforeUsed',
+      'true'
+    );
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [
+      6,
+      15,
+      23,
+      33,
+      38,
+    ];
+    $this->assertEquals($expectedWarnings, $lines);
+  }
+
+  public function testVariableArgumentListWithoutUnusedBeforeUsed() {
+    $fixtureFile = $this->getFixture('VariableArgumentListFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->ruleset->setSniffProperty(
+      'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
+      'allowUnusedParametersBeforeUsed',
+      'false'
+    );
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [
+      6,
+      15,
+      19,
+      23,
+      33,
+      38,
+      43,
+    ];
+    $this->assertEquals($expectedWarnings, $lines);
+  }
+}

Tests/VariableAnalysisSniff/fixtures/ArrowFunctionFixture.php

@@ -0,0 +1,73 @@
+<?php
+
+function arrowFunctionAsVariableWithNoWarnings($subject) {
+    $arrowFunc = fn($foo) => $foo . $subject;
+    echo $arrowFunc('hello');
+}
+
+function arrowFunctionAsVariableWithUndefinedInside($subject) {
+    $arrowFunc = fn($foo) => $foo . $bar . $subject; // undefined variable $bar
+    echo $arrowFunc('hello');
+}
+
+function arrowFunctionAsVariableWithUndefinedInClosure() {
+    $arrowFunc = fn($foo) => $foo . $subject; // undefined variable $subject
+    echo $arrowFunc('hello');
+}
+
+function arrowFunctionAsVariableWithUnusedInside($subject) {
+    $arrowFunc = fn($foo) => $subject; // unused variable $foo
+    echo $arrowFunc('hello');
+}
+
+function unusedArrowFunctionVariable($subject) {
+    $arrowFunc = fn($foo) => $foo . $subject; // unused variable $arrowFunc
+}
+
+function arrowFunctionAsVariableUsingOutsideArrow($subject) {
+    $arrowFunc = fn($foo) => $foo . $subject;
+    echo $arrowFunc('hello');
+    echo $foo; // undefined variable $foo
+}
+
+function arrowFunctionAsVariableWithUnusedInsideAfterUsed($subject) {
+    $arrowFunc = fn($foo, $bar) => $foo . $subject; // unused variable $bar
+    echo $arrowFunc('hello');
+}
+
+function arrowFunctionAsVariableWithUsedInsideAfterUnused($subject) {
+    $arrowFunc = fn($foo, $bar) => $bar . $subject; // unused variable $foo (but before used)
+    echo $arrowFunc('hello');
+}
+
+function arrowFunctionAsExpressionWithNoWarnings() {
+    $posts = [];
+    $ids = array_map(fn($post) => $post->id, $posts);
+    echo $ids;
+}
+
+function arrowFunctionAsExpressionWithUndefinedVariableInside() {
+    $posts = [];
+    $ids = array_map(fn($post) => $post->id . $foo, $posts); // undefined variable $foo
+    echo $ids;
+}
+
+function arrowFunctionAsExpressionWithUnusedVariableInside($subject) {
+    $posts = [];
+    $ids = array_map(fn($post) => $subject, $posts); // unused variable $post
+    echo $ids;
+}
+
+function arrowFunctionAsExpressionWithUsedAfterUnused($subject) { // unused variable $subject
+    $posts = [];
+    $ids = array_map(fn($foo, $post) => $post->id, $posts); // unused variable $foo (but before used)
+    echo $ids;
+}
+
+function arrowFunctionAsExpressionWithUnusedVariableOutsideArrow($subject) { //unused variable $subject
+    $posts = [];
+    $ids = array_map(fn($post) => $post->id, $posts);
+    echo $ids;
+    echo $post; // undefined variable $post;
+}
+

Tests/VariableAnalysisSniff/fixtures/VariableArgumentListFixture.php

@@ -0,0 +1,45 @@
+<?php
+function functionWithVariableArgumentsAlone(...$rest) {
+  echo $rest[0];
+}
+
+function functionWithVariableArgumentsAloneUnused(...$rest) { // unused variable $rest
+  echo "Hello";
+}
+
+function functionWithVariableArgumentsAfterOther($first, ...$rest) {
+  echo $first;
+  echo $rest[0];
+}
+
+function functionWithVariableArgumentsUnusedAfterOther($first, ...$rest) { // unused variable $rest
+  echo $first;
+}
+
+function functionWithVariableArgumentsAfterOtherUnused($first, ...$rest) { // unused variable $first (but before used)
+  echo $rest[0];
+}
+
+function functionWithVariableArgumentsUnusedAfterOtherUnused($first, ...$rest) { // unused variable $rest and unused variable $first
+  echo $first;
+}
+
+function functionWithArrowVariableArgumentsAlone($subject) {
+  $arrowFunc = fn(...$foo) => $foo[0] . $subject;
+  echo $arrowFunc('hello');
+}
+
+function functionWithArrowVariableArgumentsAloneUnused($subject) {
+  $arrowFunc = fn(...$foo) => $subject; // unused variable $foo
+  echo $arrowFunc('hello');
+}
+
+function functionWithArrowVariableArgumentsUnusedAfterOther() {
+  $arrowFunc = fn($first, ...$foo) => $first; // unused variable $foo
+  echo $arrowFunc('hello');
+}
+
+function functionWithArrowVariableArgumentsAfterOtherUnused() {
+  $arrowFunc = fn($first, ...$foo) => $foo[0]; // unused variable $first (but before used)
+  echo $arrowFunc('hello');
+}