Refactor methods to have nullable return types #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
commented
Jun 25, 2019
| * @return string | ||
| */ | ||
| protected function getScopeKey($currScope) { | ||
| if ($currScope === false) { |
Owner
Author
There was a problem hiding this comment.
I'd like to review the history of this and make sure that it's no longer necessary.
Owner
Author
There was a problem hiding this comment.
Ok, this guard is extremely old (from this change) and I think is just no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't have any functional change, but it refactors a bunch of methods which currently return a value or
falseto return a value ornull. Since PHP 7.1 supports nullable return types, this pattern has been shown to be more standard than the ... "falsable" 🤔 return type that I had been using to signal failure.