Fix issue #59 with new build-in validator NotMatch , NotEqual
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ composer run-script phpcs > php phpcs.phar --standard=PSR2 ./src FILE: /home/travis/build/Rhilip/validation/src/Rule/NotMatch.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 2 | ERROR | [x] There must be one blank line after the namespace | | declaration ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- Time: 1.47 secs; Memory: 10MB Script php phpcs.phar --standard=PSR2 ./src handling the phpcs event returned with error code 2 The command "composer run-script phpcs" exited with 2. $ cd tests && ../vendor/bin/phpunit && cd .. PHPUnit 3.7.38 by Sebastian Bergmann. Configuration read from /home/travis/build/Rhilip/validation/tests/phpunit.xml ............................................................... 63 / 192 ( 32%) .......................................F....................... 126 / 192 ( 65%) ............................................................... 189 / 192 ( 98%) ... Time: 1.46 seconds, Memory: 10.00MB There was 1 failure: 1) Sirius\Validation\Rule\NotMatchTest::testValidationWithoutItemPresent Failed asserting that false is true. /home/travis/build/Rhilip/validation/tests/src/Rule/NotMatchTest.php:32 FAILURES! Tests: 192, Assertions: 359, Failures: 1. Generating code coverage report in Clover XML format ... done Generating code coverage report in HTML format ... done The command "cd tests && ../vendor/bin/phpunit && cd .." exited with 1.
Rhilip
added a commit
to Rhilip/RidPT
that referenced
this pull request
Aug 12, 2019
with new build-in validation rule (siriusphp/validation#61), We can easily check if The password matches username.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.