share common calling path in printKeyValue

Signed-off-by: Derek Che <drc@yahoo-inc.com>
sirupsen · Jan 4, 2015 · a243bba · a243bba · rasky · Jan 18, 2015
1 parent 03377c6
commit a243bba
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/text_formatter.go b/text_formatter.go
@@ -107,18 +107,16 @@ func needsQuoting(text string) bool {
 func printKeyValue(b *bytes.Buffer, key, value interface{}) {
 	switch value.(type) {
 	case string:
-		if needsQuoting(value.(string)) {
-			fmt.Fprintf(b, "%v=%s ", key, value)
-		} else {
-			fmt.Fprintf(b, "%v=%q ", key, value)
-		}
+		break
 	case error:
-		if needsQuoting(value.(error).Error()) {
-			fmt.Fprintf(b, "%v=%s ", key, value)
-		} else {
-			fmt.Fprintf(b, "%v=%q ", key, value)
-		}
+		value = value.(error).Error()
 	default:
 		fmt.Fprintf(b, "%v=%v ", key, value)
 	}
+
+	if needsQuoting(value.(string)) {
+		fmt.Fprintf(b, "%v=%s ", key, value)
+	} else {
+		fmt.Fprintf(b, "%v=%q ", key, value)
+	}
 }