Revert #1047 #1131
Merged
Revert #1047 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2020
|
@markphelps is there a way we can get a new tag with this bugfix please? Or is it advised to downgrade instead? |
|
we should provide a new tag soon |
|
happy to create one, im assuming |
|
1.6.0 would be more appropriate, I've just merged a small feature in the TextFormatter. We should try to get back on the monthly release. I'll create an issue for the 2020-05 tag release. The first of us who is available to do it should assign to itself for sync up the work between us. |
|
I've just tagged v1.6.0 on tip of master. @thanosp feel free to upgrade to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively reverts #1047 to fix #1128, #1120, #1122 as many users are seeing deadlocks after updating to 1.5.0.
The potential reason being is that calling
WithFieldsfrom within a Hook tries to acquire the same lock, which is already acquired by the hookThis will re-open #1046