Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies #1343

Merged
merged 1 commit into from
Jul 19, 2022
Merged

update dependencies #1343

merged 1 commit into from
Jul 19, 2022

Conversation

dgsb
Copy link
Collaborator

@dgsb dgsb commented Jul 19, 2022

No description provided.

@dgsb dgsb merged commit f8bf765 into master Jul 19, 2022
@sio4
Copy link

sio4 commented Jul 19, 2022 •
edited
Loading

Hi @dgsb

It seems like this PR reverted #1337 which is related to CVE. Is it an intentional change?

@sio4 sio4 mentioned this pull request Jul 19, 2022
Closed
@thaJeztah
Copy link
Collaborator

#1337 looks odd, as it didn't update go.mod, so shouldn't have affected go.sum. Given that it's an indirect dependency, I don't see what the immediate responsibility is of logrus to update it though 🤔

@sio4
Copy link

sio4 commented Jul 19, 2022

Agree. will file a PR for it soon.

@sio4 sio4 mentioned this pull request Jul 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgsb @sio4 @thaJeztah