Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets first letter of all sirupsen imports lower-case #546

Closed
wants to merge 1 commit into from

Conversation

stweiz
Copy link

@stweiz stweiz commented May 19, 2017

This pull request sets all import paths and other references of "sirupsen" to lower case letters, so everything should be unified.

@sirupsen
Copy link
Owner

sirupsen commented Jun 2, 2017

This is going to break Logrus from too many people yet. We'll have to create a new syslog package, preferably out of repo, that imports lower-case.

@schultz9999
Copy link

schultz9999 commented Jun 26, 2017

We have a patch to go thru sources and do the manual patch once we import to vendor dir :-/ Kinda painful.

@find vendor/ -name '*.go' | xargs gofmt -w -r '"github.com/Sirupsen/logrus" -> "github.com/sirupsen/logrus"'

@schultz9999
Copy link

If it's a breaking change, why not to release a major version?

@sirupsen
Copy link
Owner

This was done in master with a bump of a major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants