Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove case insensitive import collision #786

Closed
wants to merge 1 commit into from
Closed

Remove case insensitive import collision #786

wants to merge 1 commit into from

Conversation

ch3ck
Copy link

@ch3ck ch3ck commented Jul 12, 2018

No description provided.

@ch3ck
Copy link
Author

ch3ck commented Jul 12, 2018

@dgsb here is the correct fix. I thought I'd fixed that earlier

@dgsb
Copy link
Collaborator

dgsb commented Jul 14, 2018

hello @ch3ck, I still do not understand what you are trying to do. Do you have any issue with the syslog hook ?
In your patch you are just removing a mandatory dependency.

@ch3ck
Copy link
Author

ch3ck commented Jul 20, 2018

@dgsb I was getting an inconsistency error because of the typo in the Sirupsen package reference

@dgsb
Copy link
Collaborator

dgsb commented Jul 21, 2018

@ch3ck I suspect the error comes from your local installation of logrus source files. Which command did you use to retrieve the package ?

@dgsb
Copy link
Collaborator

dgsb commented Jul 21, 2018

@ch3ck please look at my last comment in #553. The package name should be all lowercase, if any importing package name it with some uppercase letter it should be fixed. Which importing package does not build due to wrong naming ?

@dgsb dgsb closed this Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants