Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disabling alphabetical grouping in tag cloud #588

Closed
jlhg opened this issue Dec 11, 2023 · 0 comments · Fixed by #613
Closed

Support disabling alphabetical grouping in tag cloud #588

jlhg opened this issue Dec 11, 2023 · 0 comments · Fixed by #613
Labels
enhancement New feature or request

Comments

@jlhg
Copy link

jlhg commented Dec 11, 2023 •
edited
Loading

Different from the alphabetical characters, the Chinese characters are diverse and will result in one line, one tag.
It would be nice to have an option to disable the line break between groups.

Currently I use the Stylus for a workaround:

.tag-cloud .group {
  display: inline;
}
@sissbruecker sissbruecker changed the title Support disabling line breaks in tag cloud Support disabling grouping in tag cloud Jan 27, 2024
@sissbruecker sissbruecker changed the title Support disabling grouping in tag cloud Support disabling alphabetical grouping in tag cloud Jan 27, 2024
@sissbruecker sissbruecker added the enhancement New feature or request label Jan 27, 2024
jonathan-s added a commit to jonathan-s/linkding that referenced this issue Jan 28, 2024
@jonathan-s
Fix sissbruecker#588, Ideographic characters should be grouped together.
2e41b82 
Following the suggestion of using regex to find the ideographic
range in this SO answer https://stackoverflow.com/a/2718203/554903

We group the ideographic characters together, while keeping other
chinese, japanese and korean characters apart.
jonathan-s added a commit to jonathan-s/linkding that referenced this issue Jan 28, 2024
@jonathan-s
Fix sissbruecker#588, Ideographic characters should be grouped together.
93cfa88 
Following the suggestion of using regex to find the ideographic
range in this SO answer https://stackoverflow.com/a/2718203/554903

We group the ideographic characters together, while keeping other
chinese, japanese and korean characters apart.
@jonathan-s jonathan-s mentioned this issue Jan 28, 2024
Merged
sissbruecker added a commit that referenced this issue Mar 16, 2024
@jonathan-s @sissbruecker
Group ideographic characters in tag cloud (#613)
683cf52 
* Fix #588, Ideographic characters should be grouped together.
Following the suggestion of using regex to find the ideographic
range in this SO answer https://stackoverflow.com/a/2718203/554903

We group the ideographic characters together, while keeping other
chinese, japanese and korean characters apart.

* cleanup

---------

Co-authored-by: Sascha Ißbrücker <sascha.issbruecker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Group ideographic characters in tag cloud jonathan-s/linkding
2 participants
@sissbruecker @jlhg