Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepSync override to DatabaseReference #18

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

TP-113
Copy link

@TP-113 TP-113 commented Aug 13, 2024

Hello. Thanks for your good library.
I added the keepSynced method to the MockDatabaseReference because it was missing. This method is related to the local cache, so it is appropriate to do nothing in the mock.
You can merge it if you like.

@sitatec sitatec self-requested a review September 1, 2024 21:44
Copy link
Owner

@sitatec sitatec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TP-113. LGTM 👍🏾

@sitatec sitatec merged commit 16a6007 into sitatec:main Sep 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants