Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO3 13 support #159

Merged
merged 13 commits into from
Aug 23, 2024
Merged

TYPO3 13 support #159

merged 13 commits into from
Aug 23, 2024

Conversation

ulrichmathes
Copy link
Member

I'm not sure about [v13] translate without alternativeLanguageKeys as it seems we could get rid of the alternativeLanguageKeys as the core does. But this would have a higher impact and would need preparation beforehand.

I marked the ViewHelper Arguments as deprecated and in doing so preparing for the next major release? We planned to give the extension a fresh-up within this year. So that could be a better case to get rid of this parameter.

@ulrichmathes ulrichmathes linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link
Collaborator

@s2b s2b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comment, this looks fine to me. I haven't tested it though, only did code review.

I would agree with the strategy to make additional language keys work for now, but to deprecate it and to remove it with v4.

ext_emconf.php Outdated Show resolved Hide resolved
Copy link

@rafaelheid-it rafaelheid-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed this and it looks fine to me. Also seems functional - components render as they should.

@ulrichmathes
Copy link
Member Author

These changes are only compatible with fluid 2.14.1. Along with TYPO3 13.3, there will be a major update of fluid. So these changes will be released as a pre-release with hard version coupling to TYPO3 13.2 and fluid 2.14.1.

Steps forward to TYPO3 13.4 and fluid 4 will follow after Feature Freeze of TYPO3.

@ulrichmathes ulrichmathes merged commit a26f27a into master Aug 23, 2024
18 checks passed
@ulrichmathes ulrichmathes deleted the 158-typo3-13-support branch September 17, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TYPO3 13 Support
3 participants