-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYPO3 13 support #159
TYPO3 13 support #159
Conversation
With the help of rector, typo3-rector and ☕ Deeper refactoring with Dependency Injection will follow
Calling LocalizationUtility::translate() with the argument $alternativeLanguageKeys will be removed in TYPO3 v13.0. Use Locales instead. https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.html#breaking-100963-deprecated-functionality-removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small comment, this looks fine to me. I haven't tested it though, only did code review.
I would agree with the strategy to make additional language keys work for now, but to deprecate it and to remove it with v4.
72656ca
to
87b2cc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed this and it looks fine to me. Also seems functional - components render as they should.
These changes are only compatible with fluid 2.14.1. Along with TYPO3 13.3, there will be a major update of fluid. So these changes will be released as a pre-release with hard version coupling to TYPO3 13.2 and fluid 2.14.1. Steps forward to TYPO3 13.4 and fluid 4 will follow after Feature Freeze of TYPO3. |
I'm not sure about [v13] translate without alternativeLanguageKeys as it seems we could get rid of the
alternativeLanguageKeys
as the core does. But this would have a higher impact and would need preparation beforehand.I marked the ViewHelper Arguments as deprecated and in doing so preparing for the next major release? We planned to give the extension a fresh-up within this year. So that could be a better case to get rid of this parameter.