Propagation of response.encoding #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @miro-balaz aha cool. I think you can fix the format issues with |
|
I think it should be ok now, i just commited it into my branch and it automatically appeared in PR, i didn't expect that. |
beatchristen
reviewed
Mar 5, 2021
| @@ -79,8 +79,9 @@ module.exports = function(entry, response, page, options) { | |||
| status: response.status, | |||
| statusText: response.statusText, | |||
| content: { | |||
| encodig: response.encoding, | |||
There was a problem hiding this comment.
This would be really useful to have!
May I suggest to have the property corrected to encoding?
There was a problem hiding this comment.
See beatchristen@20b078e for my variant, which also tries to adhere to the 'optionality' aspect of the property.
|
Oopss, I totally missed this PR, I'll merge and change the field name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per http://www.softwareishard.com/blog/har-12-spec/#content , there is "encoding" field in content. I need to be able to use it, because in my project I am base64 encoding certain reponses.